sdedic commented on a change in pull request #2331:
URL: https://github.com/apache/netbeans/pull/2331#discussion_r488215514
##########
File path:
javafx/javafx2.project/src/org/netbeans/modules/javafx2/project/JFXProjectUtils.java
##########
@@ -1776,5 +1779,17 @@ public Void run() throws Exception {
}
}
}
+
+ private static final String MODULE_INFO = "module-info.java"; // NOI18N
+
+ // as in
org.netbeans.modules.maven.api.ModuleInfoUtils.hasModuleInfoInSource;
+ public static boolean hasModuleInfo(SourceGroupSupport support) {
+ for (File sourceRoot : support.getSourceGroupsAsFiles()) {
+ if (new File(sourceRoot, MODULE_INFO).exists()) {
Review comment:
I would prefer working with `FileObjects`, rather than converting to
`File`s, although it does not make probably big difference here. Consider
```
for (FileObject sourceRoot : support.getSourceGroups()) {
if (sourceRoot.getFileObject(MODULE_INFO) != null) {
...
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
