eirikbakke commented on pull request #2376: URL: https://github.com/apache/netbeans/pull/2376#issuecomment-694414976
> I don't see us holding back new features, just because a blessed icon is not ready or until a full new batch is done. The feature here is, "make NetBeans look better". When it comes to icons, having a consistent scheme is an essential part of "looking good". So adding one or two icons only, which will now look different next to the existing ones in the toolbar, actually makes NetBeans look worse. Thus the -1. To review, we also need to see screenshots before and after, at 100% and 200% DPI scaling. Often you'll see issues at this point, that were not evident when you were just looking at the icons in the drawing software. This means recompiling, which takes a while... longer than the time it took to make two icons. Unrelated: I also recommend keeping the icons in a single file in the drawing software (in different "artboards" or whatever is the equivalent in Inkscape), so they can be viewed side-by-side while designing them. This also facilitates cut-and-paste of shapes between icons. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
