JaroslavTulach commented on pull request #2376: URL: https://github.com/apache/netbeans/pull/2376#issuecomment-696161585
Should I know you insist on batch approach I would never let your `SVGLoader` changes in. Only when all the icons are redrawn, you'd be allowed to integrate first API change. How does that feel? Many reasons were given why batch approach is insane and cannot work in long term: > Consider a new feature where 4-5 icons are needed, that are derivates of existing ones. I would have taken the SVGs, modified them and committed them with the new feature. Your approach basicly cuts me off from this way and adds a high reliance on proprietary software and a small (not yet exiting) number of people. I agree with 95% of what has been written against your batch approach. Plus I found it totally scary that you have SVG icons, and they are not yet integrated. That's not how an open source project works. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
