eirikbakke opened a new pull request #2387: URL: https://github.com/apache/netbeans/pull/2387
By popular request, here's a PR that integrates all SVG icons that have been drawn to date, by Pete Whelpton and myself. These icons have all been drawn according to the style guide on https://issues.apache.org/jira/browse/NETBEANS-2617 , which aims to maintain the same general look as the old NetBeans icons, with some modernizations. The goal is for the new SVG icons to look OK next to the old bitmap icons (since there will always be bitmap icons in the mix for the foreseeable future). If this PR is merged, future icons should adhere to the same style for consistency. This covers only a tiny subset of unique icons in the NetBeans IDE. Some of these icons occur many times around the codebase; in those cases the SVG files have been copied to each location correspondingly as well. To see icons before and after, comparing bitmap icons in the master branch to SVG icons in this PR branch, see this spreadsheet: https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing Also attaching some screenshots. Testing was done on Windows 10 at 2x HiDPI scaling on Java 10.0.2. Also tested briefly on Java 8.0.181 (which does not support HiDPI scaling, but which will still render the SVG icons at 1x resolution). Note that there are several places where getting the SVG icons to show at full resolution will require some future tweaks (using ImageUtilities.loadImage instead of explicitly constructing an IconImage, using ImageUtilities.createDisabledIcon instead of the default button disablement mechanics etc.).      ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
