matthiasblaesing commented on a change in pull request #2382: URL: https://github.com/apache/netbeans/pull/2382#discussion_r492267350
########## File path: nbbuild/licenses/names.properties ########## @@ -19,9 +19,9 @@ GPL-2-CP=GPL v2 with Classpath exception (http://openjdk.java.net/legal/gplv2+ce Apache-2.0=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) Apache-2.0-groovy=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Apache Groovy addendums Apache-2.0-lucene=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Apache Lucene addendums -Apache-2.0-spring3.2.7=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 3.2.7 -Apache-2.0-spring4.0.1=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 4.0.1 -Apache-2.0-spring5.2.2=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 5.2.2 +Apache-2.0-spring3.2.18=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 3.2.18 +Apache-2.0-spring4.3.29=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 4.3.29 +Apache-2.0-spring5.2.9=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 5.2.9 Review comment: I would simplify these to (that needs updates at the use-sites though): - Apache-2.0-spring3 - Apache-2.0-spring4 - Apache-2.0-spring5 and change the versions at the end to "3.X", "4.X" and "5.X". - ########## File path: nbbuild/licenses/names.properties ########## @@ -19,9 +19,9 @@ GPL-2-CP=GPL v2 with Classpath exception (http://openjdk.java.net/legal/gplv2+ce Apache-2.0=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) Apache-2.0-groovy=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Apache Groovy addendums Apache-2.0-lucene=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Apache Lucene addendums -Apache-2.0-spring3.2.7=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 3.2.7 -Apache-2.0-spring4.0.1=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 4.0.1 -Apache-2.0-spring5.2.2=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 5.2.2 +Apache-2.0-spring3.2.18=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 3.2.18 +Apache-2.0-spring4.3.29=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 4.3.29 +Apache-2.0-spring5.2.9=Apache Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) with Spring addendums, version 5.2.9 Review comment: I would simplify these to (that needs updates at the use-sites though): - Apache-2.0-spring3 - Apache-2.0-spring4 - Apache-2.0-spring5 and change the versions at the end to "3.X", "4.X" and "5.X". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
