sdedic commented on a change in pull request #2399:
URL: https://github.com/apache/netbeans/pull/2399#discussion_r495565280
##########
File path:
java/java.source.base/src/org/netbeans/modules/java/source/ElementUtils.java
##########
@@ -60,6 +60,11 @@ public static TypeElement
getTypeElementByBinaryName(JavacTask task, String name
for (ModuleElement me : allModules) {
TypeElement found = getTypeElementByBinaryName(task, me, name);
+ if (result == found) {
+ // avoid returning null, partial fix for [NETBEANS-4832]
+ continue;
+ }
+
Review comment:
Not related to this bug, but a few lines below: `(elem.getKind() ==
ElementKind.CLASS || elem.getKind() == ElementKind.INTERFACE)` IMHO does not
work for `ANNOTATION_TYPE` and `ENUM`. Could be worth to fix as
`elem.getKind().isClass() || elem.getKind().isInterface` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
