matthiasblaesing commented on pull request #2397: URL: https://github.com/apache/netbeans/pull/2397#issuecomment-700859149
I have mixed feelings here. In general I prefer rebases, but that are cases where a single author creates a PR. In this case the development of the CND branch is separated from master, but runs in parallel. It depends on what we envision as "end-game". What I mean, what happens when we what to get this to master. If we agree, that a plain merge is ok, then I would merge master into cnd. If we want to keep cnd more separate a rebase would be more logical. I looked at this PR and have some doubts, that we gain much by a rebase. I think merging master might be the better option. @jlahoda what do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
