JaroslavTulach commented on a change in pull request #2429:
URL: https://github.com/apache/netbeans/pull/2429#discussion_r501879133
##########
File path:
ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -401,6 +444,51 @@ public final void
removePropertyChangeListener(PropertyChangeListener pcl) {
public DVThreadGroup[] getThreadGroups();
}
+ /**
+ * Representation of a stack frame in debugging view.
+ * Nodes representing a stack frame in debugging view model should
implement this
+ * interface.
Review comment:
Missing `@since` tag.
##########
File path:
ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -326,6 +338,37 @@ public final void
removePropertyChangeListener(PropertyChangeListener pcl) {
*/
public void makeCurrent();
+ /**
+ * Get frame count of this thread. The frame count is provided when
the thread
+ * is suspended only.
+ * @return the frame count, <code>0</code> when the thread is running.
+ */
+ public default int getFrameCount() {
+ return 0;
+ }
+
+ /**
+ * Get the stack frames of this thread. Stack frames are provided when
the thread
+ * is suspended only.
+ *
+ * @return a list of stack frames, it's empty when the thread is
running.
+ */
+ public default List<DVFrame> getFrames() {
Review comment:
Recently I wrote a [philippic against using default
methods](http://wiki.apidesign.org/wiki/BinaryCompatibleDefaultMethods), but
given the [one to many proximity](http://wiki.apidesign.org/wiki/Proximity) -
e.g. there is very likely just a single implementation of these interfaces in
the debugger impl modules - I expect no clashes and `default` methods are the
easiest way to extend the interfaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
