jlahoda commented on a change in pull request #2324:
URL: https://github.com/apache/netbeans/pull/2324#discussion_r511422657
##########
File path:
cpplite/cpplite.editor/src/org/netbeans/modules/cpplite/editor/lsp/LanguageServerImpl.java
##########
@@ -64,9 +64,10 @@
})
public class LanguageServerImpl implements LanguageServerProvider {
+ private static final boolean DEBUG =
Boolean.getBoolean("cpplite.lsp.debug");
Review comment:
The best we could do here is LOG.isLoggable(FINE) or alike instead of
DEBUG - we need to print exactly what is in the streams (as often that shows
some important piece of information), which, as far as I know, is not an ideal
usecase for Loggers. (To use Loggers, we would need to send the information to
the Logger in "batches", e.g. by lines, but that is often troublesome with this
protocol.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
