JaroslavTulach commented on a change in pull request #2490:
URL: https://github.com/apache/netbeans/pull/2490#discussion_r511709980
##########
File path: extide/gradle/src/org/netbeans/modules/gradle/GradleProjectCache.java
##########
@@ -88,6 +88,8 @@
private static AtomicLong timeInLoad = new AtomicLong();
private static AtomicInteger loadedProjects = new AtomicInteger();
+ private static final boolean DEBUG_GRADLE_INFO_ACTION =
Boolean.getBoolean("netbeans.debug.gradle.info.action"); //NOI18N
Review comment:
Isn't this an API? If so, I'd better be documented in `arch.xml` as
`<arch group="systemproperty" stability="private" .../>`
##########
File path:
extide/gradle/src/org/netbeans/modules/gradle/api/GradleBaseProjectBuilder.java
##########
@@ -125,6 +127,9 @@ void processTasks() {
void processDependencies() {
+ File gradleUserHome = (File) info.get("gradle_user_home");
Review comment:
Here the `gradle_user_home` value is read...
##########
File path:
extide/gradle/netbeans-gradle-tooling/src/main/groovy/org/netbeans/modules/gradle/tooling/NbProjectInfoBuilder.groovy
##########
@@ -99,6 +99,7 @@ class NbProjectInfoBuilder {
model.info.project_buildDir = project.buildDir;
model.info.project_projectDir = project.projectDir;
model.info.project_rootDir = project.rootDir;
+ model.info.gradle_user_home = project.gradle.gradleUserHomeDir;
Review comment:
Is `gradle_user_name` also some kind of API as it is read elsewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
