JaroslavTulach commented on a change in pull request #2493: URL: https://github.com/apache/netbeans/pull/2493#discussion_r512102542
########## File path: java/java.lsp.server/nbcode/integration/src/org/netbeans/modules/nbcode/integration/LspDialogDisplayer.java ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.nbcode.integration; + +import org.netbeans.modules.java.lsp.server.ui.AbstractDialogDisplayer; +import org.openide.DialogDisplayer; +import org.openide.util.lookup.ServiceProvider; + +/** + * + * @author sdedic + */ +//@ServiceProvider(service = DialogDisplayer.class, position = 1000) Review comment: Is `beta3` supposed to become VC1? Oct 29, so close! I asked Sváťa to propose his infrastructure changes in this PR for 12.2 as they are harmless (until we enable `@ServiceProvider`), but we may desperately need them. I am afraid we may need to download `nbjavac` if support for JDK8 is needed. Downloading shall of course only happen after asking a question - preferably through this Sváťa's infrastructure. That's my rationale. but Oct 29, is so close! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
