JaroslavTulach commented on a change in pull request #2409:
URL: https://github.com/apache/netbeans/pull/2409#discussion_r514911598
##########
File path:
enterprise/payara.common/nbproject/org-netbeans-modules-payara-common.sig
##########
@@ -1340,7 +1340,7 @@ meth public
org.netbeans.modules.payara.common.PayaraInstanceProvider getInstanc
meth public org.netbeans.modules.payara.common.PayaraJvmMode getJvmMode()
meth public org.netbeans.modules.payara.common.parser.DomainXMLChangeListener
getDomainXMLChangeListener()
meth public org.netbeans.modules.payara.tooling.data.PayaraAdminInterface
getAdminInterface()
-meth public org.netbeans.modules.payara.tooling.data.PayaraVersion getVersion()
+meth public org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI
getVersion()
Review comment:
Alas, to be binary backward compatible, you have to keep the old method
signature and introduce new method:
```
PayaraPlatformVersionAPI getVersionApi()
```
You can choose the method name, of course. Technically it would even be
`getVersion()`, but you are going to have problems to compile Java source that
contains two methods without arguments with different return types.
##########
File path:
enterprise/payara.common/nbproject/org-netbeans-modules-payara-common.sig
##########
@@ -2288,7 +2295,7 @@ meth public abstract java.lang.String getServerHome()
meth public abstract java.lang.String getServerRoot()
meth public abstract java.lang.String getUrl()
meth public abstract
org.netbeans.modules.payara.tooling.data.PayaraAdminInterface
getAdminInterface()
-meth public abstract org.netbeans.modules.payara.tooling.data.PayaraVersion
getVersion()
+meth public abstract
org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI getVersion()
Review comment:
Keep the original method, introduce new one.
##########
File path:
enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
##########
@@ -1426,14 +1445,22 @@ fld public final static
org.netbeans.modules.payara.tooling.data.PayaraVersion P
fld public final static org.netbeans.modules.payara.tooling.data.PayaraVersion
PF_5_194
fld public final static org.netbeans.modules.payara.tooling.data.PayaraVersion
PF_5_201
fld public final static org.netbeans.modules.payara.tooling.data.PayaraVersion
PF_5_202
-meth public boolean
equals(org.netbeans.modules.payara.tooling.data.PayaraVersion)
-meth public boolean
equalsMajorMinor(org.netbeans.modules.payara.tooling.data.PayaraVersion)
Review comment:
Keep original methods.
##########
File path:
enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
##########
@@ -508,7 +508,7 @@ CLSS public
org.netbeans.modules.payara.tooling.admin.CommandVersion
cons public init()
meth public static boolean
verifyResult(org.netbeans.modules.payara.tooling.admin.ResultString,org.netbeans.modules.payara.tooling.data.PayaraServer)
meth public static org.netbeans.modules.payara.tooling.admin.ResultString
getVersion(org.netbeans.modules.payara.tooling.data.PayaraServer)
-meth public static org.netbeans.modules.payara.tooling.data.PayaraVersion
getPayaraVersion(org.netbeans.modules.payara.tooling.data.PayaraServer)
+meth public static
org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI
getPayaraVersion(org.netbeans.modules.payara.tooling.data.PayaraServer)
Review comment:
Keep original and introduce new method. Probably easiest, if you choose
different name.
##########
File path:
enterprise/payara.eecommon/nbproject/org-netbeans-modules-payara-eecommon.sig
##########
@@ -1231,16 +1231,16 @@ supr
java.lang.Enum<org.netbeans.modules.payara.eecommon.api.config.JavaEEModule
hfds LOGGER,j2eeModuleTypeToValue,moduleType
CLSS public abstract
org.netbeans.modules.payara.eecommon.api.config.PayaraConfiguration
-cons protected
init(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.eecommon.api.config.J2eeModuleHelper,org.netbeans.modules.payara.tooling.data.PayaraVersion)
throws org.netbeans.modules.j2ee.deployment.common.api.ConfigurationException
-cons protected
init(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.tooling.data.PayaraVersion)
throws org.netbeans.modules.j2ee.deployment.common.api.ConfigurationException
+cons protected
init(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.eecommon.api.config.J2eeModuleHelper,org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
throws org.netbeans.modules.j2ee.deployment.common.api.ConfigurationException
Review comment:
Keep the original constructor and just introduce another one. The old
constructor shall delegate to the new one, I guess.
##########
File path:
enterprise/payara.eecommon/nbproject/org-netbeans-modules-payara-eecommon.sig
##########
@@ -1231,16 +1231,16 @@ supr
java.lang.Enum<org.netbeans.modules.payara.eecommon.api.config.JavaEEModule
hfds LOGGER,j2eeModuleTypeToValue,moduleType
CLSS public abstract
org.netbeans.modules.payara.eecommon.api.config.PayaraConfiguration
-cons protected
init(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.eecommon.api.config.J2eeModuleHelper,org.netbeans.modules.payara.tooling.data.PayaraVersion)
throws org.netbeans.modules.j2ee.deployment.common.api.ConfigurationException
-cons protected
init(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.tooling.data.PayaraVersion)
throws org.netbeans.modules.j2ee.deployment.common.api.ConfigurationException
+cons protected
init(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.eecommon.api.config.J2eeModuleHelper,org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
throws org.netbeans.modules.j2ee.deployment.common.api.ConfigurationException
+cons protected
init(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
throws org.netbeans.modules.j2ee.deployment.common.api.ConfigurationException
cons public init()
anno 0 java.lang.Deprecated()
fld protected final java.io.File primaryDD
fld protected final java.io.File secondaryDD
fld protected final
org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule module
fld protected final
org.netbeans.modules.payara.eecommon.api.config.J2eeModuleHelper moduleHelper
fld protected
org.netbeans.modules.payara.eecommon.api.config.DescriptorListener
descriptorListener
-fld protected org.netbeans.modules.payara.tooling.data.PayaraVersion version
+fld protected
org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI version
Review comment:
Keep the original file type. Make the new one (package) `private`!?
Encapsulation of fields is always better API choice.
##########
File path:
enterprise/payara.eecommon/nbproject/org-netbeans-modules-payara-eecommon.sig
##########
@@ -1265,8 +1265,8 @@ meth public abstract
org.netbeans.modules.j2ee.deployment.common.api.Datasource
meth public abstract
org.netbeans.modules.j2ee.deployment.common.api.MessageDestination
createMessageDestination(java.lang.String,org.netbeans.modules.j2ee.deployment.common.api.MessageDestination$Type)
throws org.netbeans.modules.j2ee.deployment.common.api.ConfigurationException
meth public final org.netbeans.modules.j2ee.dd.api.common.RootInterface
getStandardRootDD()
meth public final org.netbeans.modules.j2ee.dd.api.webservices.Webservices
getWebServicesRootDD()
-meth public final static org.openide.util.Pair<java.io.File,java.lang.Boolean>
getExistingResourceFile(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.tooling.data.PayaraVersion)
-meth public final static org.openide.util.Pair<java.io.File,java.lang.Boolean>
getNewResourceFile(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.tooling.data.PayaraVersion)
+meth public final static org.openide.util.Pair<java.io.File,java.lang.Boolean>
getExistingResourceFile(org.netbeans.modules.j2ee.deployment.devmodules.api.J2eeModule,org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
Review comment:
Keep old methods, introduce new ones. As the methods differ in parameter
type, their overloaded versions shall easily coexist.
##########
File path:
enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
##########
@@ -1360,7 +1360,7 @@ meth public void setPort(int)
meth public void setServerHome(java.lang.String)
meth public void setServerRoot(java.lang.String)
meth public void setUrl(java.lang.String)
-meth public void
setVersion(org.netbeans.modules.payara.tooling.data.PayaraVersion)
+meth public void
setVersion(org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
Review comment:
Keep original method, introduce new.
##########
File path:
enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
##########
@@ -1608,22 +1635,6 @@ CLSS public
org.netbeans.modules.payara.tooling.server.FetchLogSimple
cons public init(java.io.InputStream)
supr org.netbeans.modules.payara.tooling.server.FetchLog
-CLSS public org.netbeans.modules.payara.tooling.server.JpaSupport
-cons public init()
-innr public static ApiVersion
-meth public static
org.netbeans.modules.payara.tooling.server.JpaSupport$ApiVersion
getApiVersion(org.netbeans.modules.payara.tooling.data.PayaraVersion)
-supr java.lang.Object
-hfds JPA_PROVIDER_SINCE_V1,JPA_PROVIDER_SINCE_V3,jpaSupport
Review comment:
Keep and deprecate.
##########
File path:
enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
##########
@@ -2408,7 +2420,7 @@ meth public static java.lang.String
getVersionString(java.lang.String)
meth public static java.lang.String javaRootProperty(java.lang.String)
meth public static java.lang.String manifestDecode(java.lang.String)
meth public static java.lang.String serverLogFileRelativePath()
-meth public static org.netbeans.modules.payara.tooling.data.PayaraVersion
getServerVersion(java.lang.String)
+meth public static
org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI
getServerVersion(java.lang.String)
Review comment:
Keep old method, introduce new (probably with different name).
##########
File path:
enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
##########
@@ -1699,27 +1710,27 @@ supr
org.netbeans.modules.payara.tooling.server.config.PayaraTool
hfds jar
CLSS public org.netbeans.modules.payara.tooling.server.config.Config
-cons public !varargs
init(java.net.URL,org.netbeans.modules.payara.tooling.server.config.Config$Next[])
+cons public !varargs
init(org.netbeans.modules.payara.tooling.server.config.Config$Next[])
innr public static Next
supr java.lang.Object
-hfds configFiles,index
+hfds configFiles
CLSS public static
org.netbeans.modules.payara.tooling.server.config.Config$Next
outer org.netbeans.modules.payara.tooling.server.config.Config
-cons public
init(org.netbeans.modules.payara.tooling.data.PayaraVersion,java.net.URL)
+cons public init(short,java.net.URL)
supr java.lang.Object
hfds configFile,version
CLSS public org.netbeans.modules.payara.tooling.server.config.ConfigBuilder
-meth public
java.util.List<org.netbeans.modules.payara.tooling.data.PayaraLibrary>
getLibraries(org.netbeans.modules.payara.tooling.data.PayaraVersion)
-meth public org.netbeans.modules.payara.tooling.data.PayaraJavaEEConfig
getJavaEEConfig(org.netbeans.modules.payara.tooling.data.PayaraVersion)
-meth public org.netbeans.modules.payara.tooling.data.PayaraJavaSEConfig
getJavaSEConfig(org.netbeans.modules.payara.tooling.data.PayaraVersion)
+meth public
java.util.List<org.netbeans.modules.payara.tooling.data.PayaraLibrary>
getLibraries(org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
+meth public org.netbeans.modules.payara.tooling.data.PayaraJavaEEConfig
getJavaEEConfig(org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
+meth public org.netbeans.modules.payara.tooling.data.PayaraJavaSEConfig
getJavaSEConfig(org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
supr java.lang.Object
hfds
classpathHome,config,javaEEConfigCache,javaSEConfigCache,javadocsHome,libraryCache,srcHome,version
CLSS public
org.netbeans.modules.payara.tooling.server.config.ConfigBuilderProvider
cons public init()
-meth public static java.net.URL
getBuilderConfig(org.netbeans.modules.payara.tooling.data.PayaraVersion)
+meth public static java.net.URL
getBuilderConfig(org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
Review comment:
Keep original method.
##########
File path:
enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
##########
@@ -1699,27 +1710,27 @@ supr
org.netbeans.modules.payara.tooling.server.config.PayaraTool
hfds jar
CLSS public org.netbeans.modules.payara.tooling.server.config.Config
-cons public !varargs
init(java.net.URL,org.netbeans.modules.payara.tooling.server.config.Config$Next[])
+cons public !varargs
init(org.netbeans.modules.payara.tooling.server.config.Config$Next[])
innr public static Next
supr java.lang.Object
-hfds configFiles,index
+hfds configFiles
CLSS public static
org.netbeans.modules.payara.tooling.server.config.Config$Next
outer org.netbeans.modules.payara.tooling.server.config.Config
-cons public
init(org.netbeans.modules.payara.tooling.data.PayaraVersion,java.net.URL)
+cons public init(short,java.net.URL)
supr java.lang.Object
hfds configFile,version
CLSS public org.netbeans.modules.payara.tooling.server.config.ConfigBuilder
-meth public
java.util.List<org.netbeans.modules.payara.tooling.data.PayaraLibrary>
getLibraries(org.netbeans.modules.payara.tooling.data.PayaraVersion)
-meth public org.netbeans.modules.payara.tooling.data.PayaraJavaEEConfig
getJavaEEConfig(org.netbeans.modules.payara.tooling.data.PayaraVersion)
-meth public org.netbeans.modules.payara.tooling.data.PayaraJavaSEConfig
getJavaSEConfig(org.netbeans.modules.payara.tooling.data.PayaraVersion)
+meth public
java.util.List<org.netbeans.modules.payara.tooling.data.PayaraLibrary>
getLibraries(org.netbeans.modules.payara.tooling.data.PayaraPlatformVersionAPI)
Review comment:
Keep original methods.
##########
File path:
enterprise/payara.tooling/nbproject/org-netbeans-modules-payara-tooling.sig
##########
@@ -1699,27 +1710,27 @@ supr
org.netbeans.modules.payara.tooling.server.config.PayaraTool
hfds jar
CLSS public org.netbeans.modules.payara.tooling.server.config.Config
-cons public !varargs
init(java.net.URL,org.netbeans.modules.payara.tooling.server.config.Config$Next[])
+cons public !varargs
init(org.netbeans.modules.payara.tooling.server.config.Config$Next[])
innr public static Next
supr java.lang.Object
-hfds configFiles,index
+hfds configFiles
CLSS public static
org.netbeans.modules.payara.tooling.server.config.Config$Next
outer org.netbeans.modules.payara.tooling.server.config.Config
-cons public
init(org.netbeans.modules.payara.tooling.data.PayaraVersion,java.net.URL)
+cons public init(short,java.net.URL)
Review comment:
Keep original constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
