BradWalker commented on a change in pull request #2556: URL: https://github.com/apache/netbeans/pull/2556#discussion_r529045213
########## File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java ########## @@ -136,33 +136,33 @@ private static Map getElementDecls() { // Commonly used variables Set emptySet = new TreeSet(); String spaceAtt = "xml:space"; // NOI18N - Set tmpSet; + Set<String> tmpSet; //////////////////////////////////////////////// // Initialize common sets - Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N + Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N "call-template","apply-imports","for-each","value-of", // NOI18N "copy-of","number","choose","if","text","copy", // NOI18N "variable","message","fallback"})); // NOI18N - Set instructions = new TreeSet(charInstructions); - instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N + Set<String> instructions = new TreeSet<>(charInstructions); + instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N "comment","element","attribute"})); // NOI18N - Set charTemplate = charInstructions; // We don't care about PCDATA + Set<String> charTemplate = charInstructions; // We don't care about PCDATA - template = new TreeSet(instructions); + template = new TreeSet<>(instructions); template.add(resultElements); - Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N + Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N "preserve-space","output","key","decimal-format","attribute-set", // NOI18N "variable","param","template","namespace-alias"})); // NOI18N - Set topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N + Set<String> topLevelAttr = new TreeSet(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N "exclude-result-prefixes","id","version",spaceAtt})); // NOI18N - resultElementAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N + resultElementAttr = new TreeSet<>(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N Review comment: chnaged.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists