matthiasblaesing commented on a change in pull request #2557:
URL: https://github.com/apache/netbeans/pull/2557#discussion_r531224274



##########
File path: 
enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/index/CompositeComponentModel.java
##########
@@ -270,7 +270,7 @@ private static FileObject getResourcesDirectory(FileObject 
file) {
             if (folder.getName().equalsIgnoreCase("resources")) { //NOI18N
                 //check if its parent is META-INF
                 FileObject parent = folder.getParent();
-                if (parent != null && 
parent.getNameExt().startsWith("META-INF")) { //NOI18N
+                if (parent != null && parent.getName().startsWith("META-INF")) 
{ //NOI18N

Review comment:
       No I don't want to change FileObject, that sentence was meant as an 
explanation. I think FileObject is a broken abstraction, but indeed it so far 
into the base of netbeans, that it won't be changed. I prefer changes to be 
minimal. Not needing this change, dropping it is IMHO a good idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to