peedeeboy edited a comment on pull request #2558: URL: https://github.com/apache/netbeans/pull/2558#issuecomment-739328633
@isarthur Thanks for this contribution! :) I've been testing/using it for work all afternoon - I found two things: 1. I got an Exception when deleting some query text in the SQL Editor (attached). I wasn't able to replicate it a second time. Stacktrace attached: [sql_completion_stacktrace.txt](https://github.com/apache/netbeans/files/5647566/sql_completion_stacktrace.txt) 2. Changing the `Auto Popup Triggers` didn't seem to take effect for me unless Netbeans was restarted completely? @matthiasblaesing From another point of view, this PR allows you to *stop* that behavior of getting database metadata for Code Completion completely (by un-checking `Auto Popup Completion Window` in the new SQL Options), which you can't do at the moment? The status quo appears to be that once you type a `.` character after a schema in a FROM clause, Netbeans queries the database for the Tables and Views in that schema. As soon as you type a `.` after a table name / alias in the SELECT, Netbeans queries the database for column metadata. It doesn't matter if you are quick enough to not see the Code Completion dialog pop-up in NB currently, from monitoring the database session I could see those queries still happening. Once this metadata has been retrieved, it appears to be cached and future references to the same table don't cause the queries to be executed again. The additional burden of this PR is that Schema, Tables, Views, Synonyms will now also be queried for when starting to type a schema / table name in a FROM clause / SELECT. Tested against one of our biggest Oracle clusters (~160 schema / 20k tables), that initial query for schema/tables took on average ~1-5s and occasionally a worst case of 13-15s. Again, this appeared cached once retrieved and future queries didn't incur the same hit. Of course Netbeans will also do that currently if one hits Ctrl-Space in the FROM clause of a query.... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
