matthiasblaesing opened a new pull request #2589: URL: https://github.com/apache/netbeans/pull/2589
The caching of the LSP client that is rooted in project2MimeType2Server does not work. In the WeakHashMap the keys are help by weak references and the key is invalidated, once it is GCed. The URIs that are used as keys become immediately eligible for GC and thus the cache is not used at all. To fix this, use a regular HashMap with WeakReference values. The LSP Clients themselves are either strongly referenced from other components or can be collected. To not create excessive start/stops of servers, an additional strong reference is retained for a certain time after the last bind request was issued. Only after the timeout has occured, that extra reference is released and the bindings could become eligible for GC. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
