dbalek commented on a change in pull request #2587:
URL: https://github.com/apache/netbeans/pull/2587#discussion_r542172412
##########
File path: java/java.lsp.server/vscode/src/extension.ts
##########
@@ -442,6 +418,13 @@ function doActivateWithJDK(specifiedJDK: string | null,
context: ExtensionContex
commands.executeCommand('setContext', 'nbJavaLSReady', true);
c.onNotification(StatusMessageRequest.type, showStatusBarMessage);
c.onNotification(LogMessageNotification.type, (param) =>
handleLog(log, param.message));
+ c.onRequest(QuickPickRequest.type, async param => {
+ const selected = await window.showQuickPick(param.items, {
placeHolder: param.placeHolder, canPickMany: param.canPickMany });
+ return selected ? Array.isArray(selected) ? selected :
[selected] : undefined;
Review comment:
It comes as a null value that you get from received JSON. Proper null
checks are present.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
