matthiasblaesing commented on a change in pull request #2612:
URL: https://github.com/apache/netbeans/pull/2612#discussion_r550803414
##########
File path:
java/refactoring.java/src/org/netbeans/modules/refactoring/java/plugins/RenameTransformer.java
##########
@@ -254,7 +254,7 @@ public boolean accept(Element e, TypeMirror type) {
String useThis = null;
String useSuper = null;
- if (elementToFind!=null && elementToFind.getKind().isField()) {
+ if (elementToFind!=null && elementToFind.getKind().isField() &&
tree.getKind() != Tree.Kind.MEMBER_SELECT) {
Review comment:
Please add reasoning why you propose a change. In this case, the change
looks wrong, as it contradicts the check in line 262. That branch can't be
reached anymore with your change in place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
