KacerCZ commented on pull request #2640:
URL: https://github.com/apache/netbeans/pull/2640#issuecomment-755736946


   **Thank you for your work on this big feature.**
   
   I tested typing, brace matching, different formatting options and it worked 
as expected.
   
   The only thing that worked differently than I expected was blank lines (more 
their lack of) between fields with attributes.
   Box for Formatting > PHP > Blank Lines > Group Fields with PHP Doc is 
checked.
   I expected that fields with attribute will be treated as fields with PHPDoc 
and will have blank line between them.
   The same applies to constants
   
   Expected result:
   ```php
   class Person {
   
       #[Required]
       public string $name;
   
       #[Required]
       public string $login;
   
       /**
        * ISO code of country
        */
       public string $country;
       public string $street;
       public string $city;
   ```
   
   Actual result:
   ```php
   class Person {
   
       #[Required]
       public string $name;
       #[Required]
       public string $login;
   
       /**
        * ISO code of country
        */
       public string $country;
       public string $street;
       public string $city;
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to