junichi11 opened a new pull request #2674: URL: https://github.com/apache/netbeans/pull/2674
https://issues.apache.org/jira/browse/NETBEANS-4443 - https://wiki.php.net/rfc/constructor_promotion #### Part 1 - Fix the parser - Fix the `PHP80UnhandledError` - Add unit tests for the parser ##### PHP 8.0  ##### PHP 7.4  #### Part 2 - Fix the model to index promoted constructor parameters as fields - Add the `getModifier` method to the `ParameterElement` - Add unit tests for the Model, the Index, and the Navigator #### Part 3 - Fix hints and SemanticAnalysis * InitializeFieldSuggestion (Just ignore) * UnusedVariableHint (Just ignore) * WrongOrderOfArgsHint  * FieldRedeclarationHint   * SemanticAnalysis  #### Part 4 - Fix the code generator feature  #### Part 5 - Add unit tests for the formatting feature - Change the indent behavior in the following case ```php // there is no parameter class Test { public function __contruct(^){} } // before: don't add the new line class Test { public function __contruct( ^){} } // after: add the new line class Test { public function __contruct( ^ ){} } ``` ```php // this behavior is the same as before // there is a parameter class Test { public function __contruct(private int $field,^){} } // don't add the new line class Test { public function __contruct(private int $field, ^){} } ``` #### Part 6 - Fix the MarkOccurences and the GotoDeclaration features #### Part 7 - Fix the Code Completion feature - Fix a bug of the following case for the formatter ````php // example code // if there is an incomplete parameter class Example { public function __construct( private ) {} } // result: before class Example { public function __construct( private ) {} } // result: after class Example { public function __construct( private ) {} } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
