tmysik commented on a change in pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#discussion_r559088974
##########
File path: php/php.dbgp/nbproject/project.xml
##########
@@ -180,7 +180,7 @@
<build-prerequisite/>
<compile-dependency/>
<run-dependency>
- <specification-version>2.87</specification-version>
+ <specification-version>2.149</specification-version>
Review comment:
Once this is done, typically also specification version of the module
should be increased as well.
Why? If someone uses a daily build which is updated from DEV update center,
he will get the new version of PHP project - that is fine. However, since PHP
Debugger module has still the same specification version, no update is done.
Therefore, functionality from this PR will not work. If the user downloads a
fresh daily build, it will work. Therefore, the specification of the PHP
Debugger module should be increased too so the user gets its updated version
automatically too.
I am not sure where there is any DEV update center but in general, my
comment applies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
