tmysik commented on a change in pull request #2678:
URL: https://github.com/apache/netbeans/pull/2678#discussion_r559180537
##########
File path: php/php.phpdoc/src/org/netbeans/modules/php/phpdoc/PhpDocScript.java
##########
@@ -145,13 +149,24 @@ private String sanitizePath(String path) {
return path;
}
- private List<String> getParameters(String sanitizedPhpDocTarget, PhpModule
phpModule) {
+ private List<String> getAllParameters(String sanitizedPhpDocTarget,
PhpModule phpModule) {
+ List<String> params = new
ArrayList<>(getDefaultParameters(sanitizedPhpDocTarget, phpModule));
+ if (PhpDocPreferences.isConfigurationEnabled(phpModule)) {
+ String configurationPath =
PhpDocPreferences.getPhpDocConfigurationPath(phpModule);
+ if (!StringUtils.isEmpty(configurationPath)) {
+ params.add(PARAM_CONFIG);
+
params.add(sanitizePath(PhpDocPreferences.getPhpDocConfigurationPath(phpModule)));
Review comment:
> Properties are opened only if target directory for generated
documentation is not valid.
So, should not it be opened also if the enabled configuration file is
invalid, typically it does not exist?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
