JaroslavTulach commented on a change in pull request #2686:
URL: https://github.com/apache/netbeans/pull/2686#discussion_r559921517
##########
File path: java/java.lsp.server/build.xml
##########
@@ -96,6 +96,8 @@
</exec>
<exec executable="${build.dir}/vsce/node_modules/vsce/out/vsce"
failonerror="true" dir="${basedir}/vscode">
<arg value="package" />
+ <arg value="--baseImagesUrl" />
+ <arg
value="https://github.com/apache/netbeans/raw/master/java/java.lsp.server/vscode";
/>
Review comment:
Using `master` means that such images can never be removed. Wouldn't it
be more proper to obtain the actual commit ID and use it in the URL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
