JaroslavTulach commented on a change in pull request #2685: URL: https://github.com/apache/netbeans/pull/2685#discussion_r561939287
########## File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties ########## @@ -0,0 +1,21 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# yes/no/ask +ASK_OnSaving=no +# yes/no/ask +ASK_OnClosing=no Review comment: Right. I did check `java/java.lsp.server/nbcode/integration/nbproject/project.xml` and there is no dependency on `org.openide.loaders`. I can add one. ########## File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java ########## @@ -1353,19 +1331,8 @@ public void run() throws IOException { try { des.superSaveDoc(); } catch (UserQuestionException ex) { - if (GraphicsEnvironment.isHeadless()) { Review comment: Done in 4f42da8398. ########## File path: platform/openide.loaders/arch.xml ########## @@ -542,6 +542,21 @@ for more information about this. underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating engines</a>. </api> + + <api name="ASK_OnSaving" group="branding" type="export" category="stable"> Review comment: Looking at [list of branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html), it seems there used to be some convention. For example the `org.netbeans.core.netigso.FRAMEWORK_START_LEVEL` key & similar seem to spell out the package name of the bundle first and then some further info. I can follow that convention in this PR too. ########## File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties ########## @@ -0,0 +1,21 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# yes/no/ask +ASK_OnSaving=no +# yes/no/ask +ASK_OnClosing=no Review comment: Fixed in cc1eb58196680 ########## File path: platform/openide.loaders/arch.xml ########## @@ -542,6 +542,21 @@ for more information about this. underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating engines</a>. </api> + + <api name="ASK_OnSaving" group="branding" type="export" category="stable"> Review comment: Fixed globally in 1ee8dfee3601 ########## File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java ########## @@ -1353,19 +1331,8 @@ public void run() throws IOException { try { des.superSaveDoc(); } catch (UserQuestionException ex) { - if (GraphicsEnvironment.isHeadless()) { Review comment: Done in 4f42da8. ########## File path: platform/openide.loaders/arch.xml ########## @@ -542,6 +542,21 @@ for more information about this. underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating engines</a>. </api> + + <api name="ASK_OnSaving" group="branding" type="export" category="stable"> Review comment: Fixed globally in 1ee8dfe ########## File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties ########## @@ -0,0 +1,21 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# yes/no/ask +ASK_OnSaving=no +# yes/no/ask +ASK_OnClosing=no Review comment: Fixed in cc1eb58 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
