tmysik commented on a change in pull request #2704:
URL: https://github.com/apache/netbeans/pull/2704#discussion_r563031174
##########
File path: php/php.editor/tools/ASTPHP5Parser.cup
##########
@@ -2535,74 +2537,79 @@ non_empty_function_call_parameter_list:paramsList
possible_comma
;
non_empty_function_call_parameter_list ::=
-is_variadic:isVariadic expr_without_variable:var
+argument:arg
{:
List paramsList = new LinkedList();
- Expression param = var;
- if (isVariadic) {
- param = new Variadic(isVariadicleft, varright, var);
- }
- paramsList.add(param);
+ paramsList.add(arg);
RESULT = paramsList;
:}
-| is_variadic:isVariadic variable:var
+| non_empty_function_call_parameter_list:paramsList T_COMMA argument:arg
{:
- List paramsList = new LinkedList();
- Expression param = var;
- if (isVariadic) {
- param = new Variadic(isVariadicleft, varright, var);
- }
- paramsList.add(param);
+ paramsList.add(arg);
RESULT = paramsList;
:}
+;
-| T_REFERENCE:start w_variable:var
+argument ::=
+argument_expr:var
{:
- List paramsList = new LinkedList();
- Expression var_ref = new Reference(startleft, varright, var);
- paramsList.add(var_ref);
- RESULT = paramsList;
+ RESULT = var;
:}
-| error:expr
+| T_ELLIPSIS:e argument_expr:var
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
