neilcsmith-net commented on pull request #2717: URL: https://github.com/apache/netbeans/pull/2717#issuecomment-769875393
Thanks @oyarzun To be clear, the duplication of logic is not the only concern I have. The Windows launcher is the same launcher used in the zip bundles, and thus daily builds, betas, etc. It's having two methods of launching on macOS, both requiring updates and testing, one of which more likely to be used by devs, one by users, and which we're not (at the moment) in a good position to test. This looks a good change to me, and I like passing in the dock name as an environment variable. That actually covers one use I've had in platform apps for forking the launch script. In the original PR you mentioned using Apple APIs to look up userdir and cache locations. Are the values in the script always correct? If not, another use for environment variables? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
