JaroslavTulach edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773777737


   Thanks Toni for publishing nb-javac. The following diff shows how I would 
download your bits during build (tested) and runtime (not tested):
   ```
   diff --git a/java/libs.javacapi/external/binaries-list 
b/java/libs.javacapi/external/binaries-list
   index 36b5b9bc28dc..8e38bdb5b740 100644
   --- a/java/libs.javacapi/external/binaries-list
   +++ b/java/libs.javacapi/external/binaries-list
   @@ -14,4 +14,4 @@
    # KIND, either express or implied.  See the License for the
    # specific language governing permissions and limitations
    # under the License.
   -A152261F8D708A5E1A7FCDAA3981663E nb-javac-15.0.0.1-api.jar
   \ No newline at end of file
   +BFD705684E0BAD86038EAF01D33FCF7EF5D5DFB3 
com.dukescript.nbjavac:nb-javac:15.0.0.1:api
   diff --git a/java/libs.javacimpl/external/binaries-list 
b/java/libs.javacimpl/external/binaries-list
   index 1e15481e7e99..107cc9a9a0d6 100644
   --- a/java/libs.javacimpl/external/binaries-list
   +++ b/java/libs.javacimpl/external/binaries-list
   @@ -14,4 +14,4 @@
    # KIND, either express or implied.  See the License for the
    # specific language governing permissions and limitations
    # under the License.
   -0788681E011A58CE17E5583718F4919A nb-javac-15.0.0.1-impl.jar
   \ No newline at end of file
   +CBCB2F5C1CB99B672E6217BE853ABB2A0939AA72 
com.dukescript.nbjavac:nb-javac:15.0.0.1
   \ No newline at end of file
   diff --git 
a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
 
b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
   index 7d81e6c5959b..991d4db992e7 100644
   --- 
a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
   +++ 
b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
   @@ -1,5 +1,5 @@
    CRC:2454529625
    SIZE:3700020
   
-URL:https://github.com/oracle/nb-javac/releases/download/release130/0788681E011A58CE17E5583718F4919A-nb-javac-15.0.0.1-impl.jar
   +URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar
    MessageDigest: SHA-256 
f8b6a5e66e219eaa37e771f3f4dacd2a312ea1f94e8d94e48f36f7208e8fc655
    MessageDigest: SHA-512 
8c15a663def325f19a6810d929148e7b315bf61dad32433515c9aebcec952eb0916c4383a9745e3af93b3011306d43e3214318120299a78e3b847c18f26f3873
   \ No newline at end of file
   diff --git 
a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
 
b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
   index bcb929a4d315..cf85eb2011db 100644
   --- 
a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
   +++ 
b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
   @@ -1,5 +1,5 @@
    CRC:1887704140
    SIZE:246374
   
-URL:https://github.com/oracle/nb-javac/releases/download/release130/A152261F8D708A5E1A7FCDAA3981663E-nb-javac-15.0.0.1-api.jar
   +URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar:api
    MessageDigest: SHA-256 
c1fbbbcb30e283a6477248bf4adf202188d55c2e7ef9aa29d343018a68571794
    MessageDigest: SHA-512 
bc9ac9f68b21190e2d4231908ce0aa7d88c3f054c8ac226a13fd6b7fd05d63eebc59308c5a7f6df5518f9b8b01f85fd18334ce115b54e2b4994aec2253c33040
   \ No newline at end of file
   ```
   the name of the "impl" JAR changed to `nb-javac-15.0.0.1.jar` - e.g. it will 
be necessary to adjust other files in its module. I leave that and testing to 
Akshay.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to