JaroslavTulach commented on pull request #2732: URL: https://github.com/apache/netbeans/pull/2732#issuecomment-773999233
I am seeing following classes in the API: `J2SEPlatformCreator`, `J2SEPlatformDefaultJavadoc`, `J2SEPlatformDefaultSources`, that's a reasonable size, I guess. > Is these still some API review process? Just a regular review before integration with more attention to API aspects. > would org-netbeans-modules-java-j2seplatform.sig need any tweaks? No. Keep it unchanged. > should I go and remove impl dependencies for existing friends Hopefully there are no "implementation" dependencies. Friend modules use a regular dependency. You can keep it unchanged, but: - you need to version your change - see [this essay](http://wiki.apidesign.org/wiki/FriendDependencies) - otherwise your module would get `NoClassDefFoundError` - add an `apichanges.xml` entry describing the module went public - your module has to depend on the new version that made this module public - change `arch.xml` to say the API is public - make sure the module is listed among public API modules in `nbbuild/build.properties` - try to build `ant build-javadoc` to verify everything looks sane at the end I am assuming your module is going to download and install various JDKs. Good luck with it! I hope to see it on our plugin portal soon. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
