neilcsmith-net commented on pull request #43: URL: https://github.com/apache/netbeans-tools/pull/43#issuecomment-774495938
> The updates.xml.gz used as base is read from the local file. Thanks, yes wasn't sure exactly where the contents for that are taken from though? eg. this line is possibly concerning https://github.com/apache/netbeans-tools/blob/8d8fa220d5482427ca381fdcf1724f09b5b04007/proxy-chooser/updates.php#L120 Doesn't that assume all links are relative? But the updates.xml from the release isn't what's actually served to users. Check the updates file for 12.0 for instance - that currently has a number of absolute URLs, and directly to closer.lua. That is currently how updates are shipped. We need to be able to handle that usage, and I wasn't sure if this code can at the moment? Also, ideallly the updates should use the same mirror as selected for the rest. When archiving we also add notifications to the XML about new releases. And there are potentially other cases for editing that file that don't assume relative links. Key thing is that whatever solution we have here has to handle the fact that there is no file on dist.a.o that will, or can, have the required contents. One minor point - the crunch point here "closer.lua is hit many times and can cause blocks because this is detected as abuse of the the download system" I've not seen - the more likely rate limiting you'll hit is netbeans.a.o to netbeans-vm1.a.o. You can see this using the Ant platform scripts to download the clusters in a build. The proxy chooser should hopefully fix that issue too though. And it's a use case we should check against too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
