[GitHub] [netbeans] DevCharly opened a new pull request #2872: FlatLaf: update from 1.1.1 to 1.1.2 and fix/improve options

Wed, 07 Apr 2021 06:47:24 -0700 


DevCharly opened a new pull request #2872:
URL: https://github.com/apache/netbeans/pull/2872


   This is a follow up to #2839, which unfortunately causes some problems in 
open editors when changing "Unified title bar" flag in FlatLaf Options: the 
line numbers ruler was hidden and sometimes I had the impression that some 
editing features no longer work. The problem was that `FlatLaf.updateUI()` was 
used to update all UI delegates. This PR no longer does this.
   
   Changes:
   - update from 1.1.1 to 1.1.2
   - Options: option "Unified window title bar" is now enabled by default 
because this looks much better, especially in dark theme
   - Options: disabling option "Window decorations" now works without restart
   - Options: changing option "Unified window title bar" now works without 
`FlatLaf.updateUI()`, which fixes lost line numbers in editors
   - Options: if option "Unified window title bar" is enabled, categories area 
gets same background as window title bar
   - Options: moved categories area colors to FlatLaf properties files
     (this partially implements 
https://issues.apache.org/jira/browse/NETBEANS-3528 and removes all FlatLaf 
specific code from `OptionsPanel.java`, which was added in #1703)
   
   Comparison of  "Unified window title bar" enabled/disabled:
   
   
![image](https://user-images.githubusercontent.com/5604048/113875999-9801db80-97b7-11eb-8e89-2566084395b2.png)
   
   
![image](https://user-images.githubusercontent.com/5604048/113876113-b7006d80-97b7-11eb-8622-a4ea44793b26.png)
   
   
![image](https://user-images.githubusercontent.com/5604048/113876138-bd8ee500-97b7-11eb-8892-4a89d69a9418.png)
   
   
![image](https://user-images.githubusercontent.com/5604048/113876167-c54e8980-97b7-11eb-82b6-7386b4371301.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to