pedro-w commented on pull request #2865: URL: https://github.com/apache/netbeans/pull/2865#issuecomment-819691423
It is possible, though, to run it without nb-javac and I believe it does make sense to test the code without as the users might be running NB without nb-javac. What I found is that only one additional test was failing (the switch expression one) and that test did not have a version check in it, whereas the other tests in the same file did. I guess it was just missed out by accident? So, I copy-pasted the check from another function in the file and that is commit 8add5a26905d05ad16b7f8c9f5f4c4c3f323dcd0 With this, all tests in the file pass for me. I also added another clean up commit to the test file - 233ae402baa0682ac164517495745af6a518842f - I limited this to just the things the IDE flagged up (obsolete API, unused functions etc.) I don't know if you want this as it doesn't add a huge amount of benefit to the code! Please let me know, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
