entlicher commented on a change in pull request #2913:
URL: https://github.com/apache/netbeans/pull/2913#discussion_r620649705
##########
File path:
cpplite/cpplite.debugger/src/org/netbeans/modules/cpplite/debugger/ni/NIDebuggerProviderImpl.java
##########
@@ -119,9 +121,15 @@ public void finished() {
completed.complete(null);
}
});
+ started.release();
debugger.execRun();
return engineProcess.second();
}, executionDescriptor, displayName).run();
+ // Wait for the debugger to actually start up.
+ // This is necessary to be able to safely call other methods on the
NIDebuggerProvider.
+ try {
+ started.acquire();
+ } catch (InterruptedException ex) {}
Review comment:
It's true that it's safer to replace it with `acquireUninterruptibly`.
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
