JaroslavTulach opened a new pull request #2949:
URL: https://github.com/apache/netbeans/pull/2949


   VisualVM project decided to pursue its own development of `profiler.lib` and 
`profiler.oql` since 
[affe1eb1308554](https://github.com/oracle/visualvm/commit/affe1eb1308554d4df8fcdd6308e9fa4e3f3787).
 Understandable given the complicated situation NetBeans project was in at that 
time. However since then the Apache NetBeans project has proven its maturity, 
ability to deliver and produce regular quarterly releases, as well as upload 
all the NetBeans libraries to Maven central. Maven central is the default way 
of distributing and consuming the libraries and I am reusing `profiler.lib` in 
[Insight 
project](https://github.com/oracle/graal/blob/master/tools/docs/Insight.md). 
While doing so, I noticed slight differences in behavior and in order to mimize 
them I am proposing applying them to Apache NetBeans `profiler.lib` and 
`profiler.oql` libraries.
   
   First of all I took the changes from git diff 
affe1eb1308554](https://github.com/oracle/visualvm/commit/affe1eb1308554d4df8fcdd6308e9fa4e3f3787)...
   [e88fe0edbb](https://github.com/oracle/visualvm/commit/e88fe0edbb] and 
filtered them out to contain only the changes in above two libraries:
   ```bash
   filterdiff -i '*/visualvm/libs.profiler/lib.profiler/**' | sed 
s#visualvm/libs.profiler/lib.profiler#profiler/lib.profiler#g | sed 
s#org/graalvm/visualvm/lib/jfluid#org/netbeans/lib/profiler#g`
   ```
   then I applied the changes as a07981a and resolved remaining clashes 
manually. Now I am creating a pull request to let the integration tests run and 
notify me of remaining issues that need to be polished.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to