sdedic commented on pull request #2948: URL: https://github.com/apache/netbeans/pull/2948#issuecomment-840530530
> However there is no change listener in [ActionProvider](https://bits.netbeans.org/12.3/javadoc/org-netbeans-modules-projectapi/org/netbeans/spi/project/ActionProvider.html) and there are no notifications of state changes. As such I'd prefer to just pass `ProjectConfiguration` in the `Lookup` when `invokeAction` or `isActionEnabled` is called. I don't quite understand why you expect stateful behaviour from just a context-bound accessor. The original interface acts on the **active** configuration, and it's free to change `enable` status of an action at any time: each `isActionEnabled` invocation may produce a different result, if i.e. active configuration changes - and the original interface does not provide any event source for this change. Why is the statefulness/observable pattern required when a configuration-bound instance is created ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
