sdedic edited a comment on pull request #2948: URL: https://github.com/apache/netbeans/pull/2948#issuecomment-841148947
After some discussion ... **agreed on moving the `ProjectConfiguration` to the Lookup**. I'll cross-document it in ActionProvider APIs as well so it is easier to find. For the records (persisting the off-PR conversation): - `ExplicitProcessParameters` is a different beast: the `execution` module does not know Projects, and vice versa. `ActionProvider` implementation in the process does not process that in any way, directly. Only code deeply in the execution infrastructure knows about it. So this is a clear case for Lookup. - `ActionProgress` is a better example; but unlike active `ProjectConfiguration`, it affects just `invokeAction`, not e.g. `getSupportedActions()`. - With the presented approach we face higher client costs: the client has to do `instanceof`s, ... - since the client actually uses SPI interface in the current design. If there was an API (delegating to the SPI), or even a helper utility method, the cost would be far less. - For compatibility (see `ProjectConfigurationProvider` docs), the `ProjectConfiguration` has to be in the Lookup anyway. So as a wrap-up: - will remove the `ConfigurationAware` - [Create ProjectActions API](https://issues.apache.org/jira/browse/NETBEANS-5680) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
