[GitHub] [netbeans] eirikbakke opened a new pull request #2970: [NETBEANS-5698] Fix tabcontrol painting on MacOS retina displays (Aqua LAF)

[GitBox]

eirikbakke opened a new pull request #2970:
URL: https://github.com/apache/netbeans/pull/2970


   This PR fixes scaling problems that occur in the window system tabs on the 
Aqua LAF on Retina displays (2x HiDPI scaling). All MacBooks and other Apple 
displays use retina scaling these days.
   
   The fix is to use Graphics.fillRect instead of Graphics.drawLine; see the 
comment in the code. The patch adds a new "drawLine" utility method in the tab 
displayer UI classes for this purpose, and then does a plain search-and-replace 
of "g.drawLine(" with "drawLine(g, ", with no other changes.
   
   Note that on MacOS, standard UI panel borders are two device pixels thick on 
Retina screens. So scaling everything up 2x on Retina displays is the right 
thing to do, and looks consistent with native MacOS apps.
   
   The fixes are illustrated here, with retina scaling (2x) enabled:
   
   <img width="815" alt="Summary" 
src="https://user-images.githubusercontent.com/886243/119020916-cb19bc00-b96c-11eb-8dd5-118c3c366549.png";>
   
   Tested on both Java 8 and Java 11. Full IDE screenshots included below.
   
   ### Before:
   <img width="907" alt="Java 11 Tabs Old" 
src="https://user-images.githubusercontent.com/886243/119020111-dc15fd80-b96b-11eb-9cee-a65fec011f11.png";>
   
   ### After:
   <img width="907" alt="Java 11 Tabs New" 
src="https://user-images.githubusercontent.com/886243/119020154-e7692900-b96b-11eb-8a8b-b12b302976a8.png";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists