matthiasblaesing commented on a change in pull request #2977:
URL: https://github.com/apache/netbeans/pull/2977#discussion_r640096725
##########
File path:
java/maven/test/unit/src/org/netbeans/modules/maven/queries/UnitTestsCompilerOptionsQueryImplTest.java
##########
@@ -59,13 +60,19 @@ public void testNoCompilerPluginSpecified() throws
Exception {
TestFileUtils.writeFile(wd,
"src/test/java/module-info.java",
"module test { requires testng; }\n");
+ TestFileUtils.writeFile(wd,
+ "target/generated-sources/java/test/Gen.java",
+ "package test;\n" +
+ "public class Gen {}\n");
FileObject testSource =
TestFileUtils.writeFile(wd,
"src/test/java/test/APITest.java",
"package test;\n" +
"public class APITest {}\n");
assertEquals(Arrays.asList("--patch-module",
- "test=" +
FileUtil.toFile(wd.getFileObject("src/main/java")).getAbsolutePath()),
+ "test=" +
FileUtil.toFile(wd.getFileObject("src/main/java")).toURI().getPath() +
Review comment:
Are paths or URIs expected for patch-module? If paths are expected, this
will break for example for spaces ("%20" vs " "). The documentation seems to be
thin on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
