JaroslavTulach commented on a change in pull request #2984:
URL: https://github.com/apache/netbeans/pull/2984#discussion_r642927967
##########
File path:
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionHandler.java
##########
@@ -53,12 +61,14 @@
import org.netbeans.modules.groovy.editor.api.lexer.LexUtilities;
import org.netbeans.modules.groovy.editor.utils.GroovyUtils;
import
org.netbeans.modules.groovy.editor.api.completion.util.CompletionContext;
+import org.netbeans.modules.groovy.editor.java.JavaElementHandle;
import org.netbeans.modules.groovy.support.api.GroovySettings;
+import org.openide.util.Exceptions;
import org.openide.util.NbBundle;
import org.openide.util.Utilities;
import org.openide.util.WeakListeners;
-public class CompletionHandler implements CodeCompletionHandler {
+public class CompletionHandler implements CodeCompletionHandler2 {
Review comment:
`CodeCompletionHandler2` has been introduced in version of 2.43 of the
csl.api. Please update dependency from 2.21 to 2.43.
##########
File path:
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionItem.java
##########
@@ -910,30 +955,18 @@ public boolean equals(Object obj) {
}
}
- public static class JavaFieldItem extends CompletionItem {
-
- private final String className;
- private final String name;
+ public static class JavaFieldItem extends JavaElementItem {
Review comment:
API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
