sdedic commented on a change in pull request #2986:
URL: https://github.com/apache/netbeans/pull/2986#discussion_r645341987
##########
File path:
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbProcessConsole.java
##########
@@ -71,7 +71,18 @@ public void stop() {
protected InputStream getStdIn() throws IOException {
synchronized (this) {
if (inputSink == null) {
- inputSink = new PipedInputStream(inputSource);
+ inputSink = new PipedInputStream(inputSource) {
+ @Override
+ public void close() throws IOException {
+ synchronized(this) {
+ super.close();
+ // Bug in Piped*Stream: in.close() closes, but does
+ // not unblock waiters, nor returns -1 from writer
to
+ // stop waiting. Close the writer - will also
notifyAll().
+ inputSource.close();
Review comment:
Without this explicit close, the `PipedInputStream` won't wake up or
receive `-1` from the writer (which causes its `read` to return and release
lock):
```
"pool-2-thread-1" #48 prio=5 os_prio=0 cpu=305.23ms elapsed=44.59s
tid=0x00007feefc052800 nid=0x54c4 waiting for monitor entry
[0x00007fef03703000]
java.lang.Thread.State: BLOCKED (on object monitor)
at
sun.nio.cs.StreamDecoder.close([email protected]/StreamDecoder.java:190)
- waiting to lock <0x000000060d8752c0> (a
org.netbeans.modules.java.lsp.server.ui.AbstractLspInputOutputProvider$LspIO$1)
at
java.io.InputStreamReader.close([email protected]/InputStreamReader.java:200)
at
org.netbeans.modules.java.lsp.server.ui.AbstractLspInputOutputProvider$LspIO$1.close(AbstractLspInputOutputProvider.java:152)
at
org.openide.util.io.ReaderInputStream.close(ReaderInputStream.java:130)
at
org.netbeans.modules.gradle.execute.GradleDaemonExecutor.closeInOutErr(GradleDaemonExecutor.java:348)
- locked <0x000000060ccc1400> (a
org.netbeans.modules.gradle.execute.GradleDaemonExecutor)
at
org.netbeans.modules.gradle.execute.GradleDaemonExecutor.cancel(GradleDaemonExecutor.java:368)
at
org.netbeans.modules.progress.spi.InternalHandle.requestCancel(InternalHandle.java:364)
at
org.netbeans.modules.java.lsp.server.progress.LspInternalHandle.forceRequestCancel(LspInternalHandle.java:93)
at
org.netbeans.modules.java.lsp.server.debugging.DebugAdapterContext.requestProcessTermination(DebugAdapterContext.java:140)
at
org.netbeans.modules.java.lsp.server.debugging.launch.NbDisconnectRequestHandler.destroyDebugSession(NbDisconnectRequestHandler.java:49)
at
org.netbeans.modules.java.lsp.server.debugging.launch.NbDisconnectRequestHandler.disconnect(NbDisconnectRequestHandler.java:35)
at
org.netbeans.modules.java.lsp.server.debugging.NbProtocolServer.disconnect(NbProtocolServer.java:180)
at
jdk.internal.reflect.NativeMethodAccessorImpl.invoke0([email protected]/Native
Method)
at
jdk.internal.reflect.NativeMethodAccessorImpl.invoke([email protected]/NativeMethodAccessorImpl.java:62)
at
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke([email protected]/DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke([email protected]/Method.java:566)
at
org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.lambda$null$0(GenericEndpoint.java:65)
at
org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint$$Lambda$216/0x000000080043d440.apply(Unknown
Source)
at
org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.request(GenericEndpoint.java:120)
at
org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleRequest(RemoteEndpoint.java:261)
at
org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:190)
at
org.netbeans.modules.java.lsp.server.debugging.Debugger$ConsumeWithLookup.lambda$consume$0(Debugger.java:92)
at
org.netbeans.modules.java.lsp.server.debugging.Debugger$ConsumeWithLookup$$Lambda$259/0x00000008005ab040.run(Unknown
Source)
at
org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
at
org.netbeans.modules.java.lsp.server.debugging.Debugger$ConsumeWithLookup.consume(Debugger.java:90)
at
org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:194)
at
org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:94)
at
org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:113)
at
java.util.concurrent.Executors$RunnableAdapter.call([email protected]/Executors.java:515)
at
java.util.concurrent.FutureTask.run([email protected]/FutureTask.java:264)
at
java.util.concurrent.ThreadPoolExecutor.runWorker([email protected]/ThreadPoolExecutor.java:1128)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run([email protected]/ThreadPoolExecutor.java:628)
at java.lang.Thread.run([email protected]/Thread.java:834)
...
"DisconnectableInputStream source reader" #58 daemon prio=5 os_prio=0
cpu=2.40ms elapsed=42.47s tid=0x00007feee14f8800 nid=0x54d6 in Object.wait()
[0x00007fef03503000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait([email protected]/Native Method)
- waiting on <no object reference available>
at
java.io.PipedInputStream.read([email protected]/PipedInputStream.java:326)
- waiting to re-lock in wait() <0x000000060d8752e0> (a
org.netbeans.modules.java.lsp.server.debugging.launch.NbProcessConsole$1)
at
java.io.PipedInputStream.read([email protected]/PipedInputStream.java:377)
- waiting to re-lock in wait() <0x000000060d8752e0> (a
org.netbeans.modules.java.lsp.server.debugging.launch.NbProcessConsole$1)
at
sun.nio.cs.StreamDecoder.readBytes([email protected]/StreamDecoder.java:284)
at
sun.nio.cs.StreamDecoder.implRead([email protected]/StreamDecoder.java:326)
at
sun.nio.cs.StreamDecoder.read([email protected]/StreamDecoder.java:178)
- locked <0x000000060d8752c0> (a
org.netbeans.modules.java.lsp.server.ui.AbstractLspInputOutputProvider$LspIO$1)
at
sun.nio.cs.StreamDecoder.read0([email protected]/StreamDecoder.java:127)
- locked <0x000000060d8752c0> (a
org.netbeans.modules.java.lsp.server.ui.AbstractLspInputOutputProvider$LspIO$1)
at
sun.nio.cs.StreamDecoder.read([email protected]/StreamDecoder.java:112)
at
java.io.InputStreamReader.read([email protected]/InputStreamReader.java:168)
at
org.openide.util.io.ReaderInputStream.read(ReaderInputStream.java:65)
at
org.openide.util.io.ReaderInputStream.read(ReaderInputStream.java:88)
at
org.gradle.util.DisconnectableInputStream$1.run(DisconnectableInputStream.java:98)
at java.lang.Thread.run([email protected]/Thread.java:834)
```
[super.close()](https://github.com/apache/netbeans/pull/2986/files#diff-564ac1b5c2cb7bbbee4cd2345811beac908f8cf0b317e0c4555a76496362b43bR152)
would block on monitor of this Piped stream that would be still waiting on
(never coming) input.
Full thread dump:
[threaddump-pipedstream.txt](https://github.com/apache/netbeans/files/6596423/threaddump-pipedstream.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
