sdedic commented on a change in pull request #2995:
URL: https://github.com/apache/netbeans/pull/2995#discussion_r650711083
##########
File path:
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java
##########
@@ -1088,6 +1121,39 @@ public Void visitMethod(MethodTree tree, Void p) {
return result;
}
+ private List<Pair<String, String>> getProjectConfigurations(JavaSource
source) {
+ for (FileObject fo : source.getFileObjects()) {
+ Project p = FileOwnerQuery.getOwner(fo);
+ if (p != null) {
+ ProjectConfigurationProvider<ProjectConfiguration> provider =
p.getLookup().lookup(ProjectConfigurationProvider.class);
+ List<Pair<String, String>> configDispNames = new ArrayList<>();
+ if (provider != null) {
+ boolean skippedFirst = false;
+ for (ProjectConfiguration c :
provider.getConfigurations()) {
+ if (skippedFirst) {
+ String runConfig = null;
+ String debugConfig = null;
+ if (provider.configurationAffectsAction(c,
ActionProvider.COMMAND_RUN_SINGLE)) {
Review comment:
I am not sure about this approach. If a Configuration does not define an
action mapping, Maven and Gradle will fall back to the default (implicit)
configuration's behaviour. This condition seems to disable the action if a
configuration does not define a specialization for it. I think the semantic for
LSP client diverges from the semantic seen by the IDE / headless LSP server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
