entlicher commented on a change in pull request #3025: URL: https://github.com/apache/netbeans/pull/3025#discussion_r662579123
########## File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/attach/AttachConfigurationCompletion.java ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.java.lsp.server.debugging.attach; + +import com.google.gson.stream.JsonWriter; +import java.io.IOException; +import java.io.StringWriter; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.function.Supplier; +import java.util.stream.Collectors; + +import org.eclipse.lsp4j.CompletionItem; +import org.eclipse.lsp4j.InsertTextFormat; +import org.netbeans.api.project.Project; +import org.netbeans.modules.java.lsp.server.Utils; +import org.netbeans.modules.java.lsp.server.protocol.LaunchConfigurationCompletion; +import org.openide.util.Exceptions; +import org.openide.util.lookup.ServiceProvider; + +/** + * Completion of debugger attach configurations. + * + * @author Martin Entlicher + */ +@ServiceProvider(service = LaunchConfigurationCompletion.class, position = 200) +public class AttachConfigurationCompletion implements LaunchConfigurationCompletion { + + @Override + public CompletableFuture<List<CompletionItem>> configurations(Supplier<CompletableFuture<Project>> projectSupplier) { + return CompletableFuture.supplyAsync(() -> { + return createCompletion(AttachConfigurations.get()); + }, AttachConfigurations.RP); + } + + @Override + public CompletableFuture<List<CompletionItem>> attributes(Supplier<CompletableFuture<Project>> projectSupplier, Map<String, Object> currentAttributes) { + return CompletableFuture.supplyAsync(() -> { + return createAttributesCompletion(AttachConfigurations.get(), currentAttributes); + }, AttachConfigurations.RP); + } + + @Override + public CompletableFuture<List<CompletionItem>> attributeValues(Supplier<CompletableFuture<Project>> projectSupplier, Map<String, Object> currentAttributes, String attribute) { + return CompletableFuture.completedFuture(Collections.emptyList()); + } + + private static List<CompletionItem> createCompletion(AttachConfigurations attachConfigurations) { + return attachConfigurations.getConfigurations().stream().map(configAttrs -> createCompletion(configAttrs)).collect(Collectors.toList()); + } + + private static CompletionItem createCompletion(ConfigurationAttributes configAttrs) { + CompletionItem ci = new CompletionItem("Java 8+: " + configAttrs.getName()); // NOI18N + StringWriter sw = new StringWriter(); + try (JsonWriter w = new JsonWriter(sw)) { + w.setIndent("\t"); // NOI18N + w.beginObject(); + w.name("name").value("${1:" + Utils.escapeCompletionSnippetSpecialChars(configAttrs.getName()) + "}"); // NOI18N + w.name("type").value(AttachConfigurations.CONFIG_TYPE); // NOI18N + w.name("request").value(AttachConfigurations.CONFIG_REQUEST); // NOI18N + int locationIndex = 2; + for (Map.Entry<String, ConfigurationAttribute> entry : configAttrs.getAttributes().entrySet()) { + ConfigurationAttribute ca = entry.getValue(); + if (ca.isMustSpecify()) { + String value = ca.getDefaultValue(); + if (value.startsWith("${command:")) { // Do not suggest to customize values provided by commands // NOI18N + value = Utils.escapeCompletionSnippetSpecialChars(encode2JSON(value)); + } else { + value = "${" + (locationIndex++) + (value.isEmpty() ? "}" : ":" + Utils.escapeCompletionSnippetSpecialChars(encode2JSON(value)) + "}"); // NOI18N + } + // We have pre-encoded the value in order not to encode the completion snippet escape characters + w.name(entry.getKey()).jsonValue("\"" + value + "\""); + } + } + w.endObject(); + w.flush(); + } catch (IOException ex) { + Exceptions.printStackTrace(ex); + } + ci.setInsertText(sw.toString()); + ci.setInsertTextFormat(InsertTextFormat.Snippet); + ci.setDocumentation(configAttrs.getDescription()); + return ci; + } + + private static String encode2JSON(String value) { + if (value.isEmpty()) { + return value; + } + StringWriter sw = new StringWriter(); + try (JsonWriter w = new JsonWriter(sw)) { + w.beginArray(); + w.value(value); + w.endArray(); + w.flush(); + } catch (IOException ex) { + Exceptions.printStackTrace(ex); + } + String encoded = sw.toString(); + // We have ["value"], remove the array and quotes + return encoded.substring(2, encoded.length() - 2); + } + + private static List<CompletionItem> createAttributesCompletion(AttachConfigurations attachConfigurations, Map<String, Object> currentAttributes) { + List<CompletionItem> completionItems = null; + ConfigurationAttributes currentConfiguration = attachConfigurations.findConfiguration(currentAttributes); + if (currentConfiguration != null) { + Map<String, ConfigurationAttribute> attributes = currentConfiguration.getAttributes(); + for (Map.Entry<String, ConfigurationAttribute> entry : attributes.entrySet()) { + String attrName = entry.getKey(); + if (!currentAttributes.containsKey(attrName)) { + StringWriter sw = new StringWriter(); + try (JsonWriter w = new JsonWriter(sw)) { + w.beginObject(); + w.name(attrName).value(entry.getValue().getDefaultValue()); Review comment: Yes because `value()` does the escaping itself. `jsonValue()` does not do the escaping. We need to apply escaping ourselfs and use the `jsonValue()` only when we use `${}` in the snippets so that we do not get it escaped for the snippet apply logic to work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
