sdedic commented on a change in pull request #1069:
URL: https://github.com/apache/netbeans/pull/1069#discussion_r663699027



##########
File path: 
java/maven.junit.ui/src/org/netbeans/modules/maven/junit/ui/MavenJUnitNodeOpener.java
##########
@@ -144,6 +159,24 @@ public void run(CompilationController 
compilationController) throws Exception {
             UIJavaUtils.openFile(fo2open[0], (int) line[0]);
         }
     }
+    
+    private Element findInnermostTypeElement(Element containingTypeElement, 
List<? extends String> targetInnerClassNames) {

Review comment:
       No need to stub `CompilationController:` refactor code to have the 
tested part callable and save make accessors so the test can collect the 
computed data. I.e. make the UserTask a package-private member class, so the 
test can instantiate it. Create sources in test data, then process it using 
JavaSource.parse(). Call the tested code with (real) CompilationController 
instance and observe the outcome.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to