dbalek commented on a change in pull request #3045:
URL: https://github.com/apache/netbeans/pull/3045#discussion_r668635020
##########
File path:
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchDelegate.java
##########
@@ -291,14 +291,14 @@ public void propertyChange(PropertyChangeEvent evt) {
}
}
});
- } else {
- launchFuture.complete(null);
}
-
Lookups.executeWith(launchCtx, () -> {
providerAndCommand.first().invokeAction(providerAndCommand.second(), lookup);
Review comment:
There is no need for waiting for action to finish but rather to ensure
the action has already started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
