jkovalsky commented on a change in pull request #45:
URL: https://github.com/apache/netbeans-tools/pull/45#discussion_r673109182



##########
File path: pp3/au/build-dashboard_v2.php
##########
@@ -32,7 +32,7 @@
 $debug = false;
 
 // lockfile
-$lockfile = '/tmp/run.lck';
+$lockfile = './tmp/run.lck';

Review comment:
       Should not we use `LOCKFILE` defined in the `config.php` file?

##########
File path: pp3/au/config.php
##########
@@ -3,19 +3,18 @@
 /**
  * Config variables 
  */
-DEFINE('LOGFILE_PATH', '/tmp');
+DEFINE('LOGFILE_PATH', './tmp');
 DEFINE('ADMIN_EMAIL', '[email protected]');

Review comment:
       In my opinion, some mailing list would be better for import problem 
warnings but until we agree on creating one I volunteer to substitute @jpirek 
with my [email protected] e-mail.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to