eirikbakke commented on pull request #3043: URL: https://github.com/apache/netbeans/pull/3043#issuecomment-886262967
Thanks for revising! I tested the latest patch and it works, including with multiple selection and with both the default package and other packages. One issue for brief discussion: the name "Copy Fully Qualified Class Name" is very long, making the context menu significantly wider (being the widest item in the menu) on Linux and Windows 10 (but probably not on MacOS). Thought it's probably the most descriptive name. I'd be inclined to keep it as it is, if no one has a better idea. Last, before we can squash-and-merge, I think the author of the PR needs to have a proper email address publicly visible on github, which then becomes part of NetBeans repository's public history. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
