moacirrf commented on a change in pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077#discussion_r678251195
##########
File path:
java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java
##########
@@ -424,9 +421,8 @@ public void run() {
}
//skip envs, these get filled in later.
//#228901 since u21 we need to use cmd /c to execute on windows,
quotes get escaped and when there is space in value, the value gets wrapped in
quotes.
- String value = (Utilities.isWindows() ?
entry.getValue().replace(quote, escaped) : entry.getValue().replace(quote,
"'"));
+ String value = (Utilities.isWindows() ?
entry.getValue().replace(quote, "") : entry.getValue().replace(quote, "'"));
if (Utilities.isWindows() && value.endsWith("\"")) {
- //#201132 property cannot end with 2 double quotes, add a
space to the end after our quote to prevent the state
Review comment:
humm..I will put again this comment
##########
File path:
java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java
##########
@@ -424,9 +421,8 @@ public void run() {
}
//skip envs, these get filled in later.
//#228901 since u21 we need to use cmd /c to execute on windows,
quotes get escaped and when there is space in value, the value gets wrapped in
quotes.
- String value = (Utilities.isWindows() ?
entry.getValue().replace(quote, escaped) : entry.getValue().replace(quote,
"'"));
+ String value = (Utilities.isWindows() ?
entry.getValue().replace(quote, "") : entry.getValue().replace(quote, "'"));
if (Utilities.isWindows() && value.endsWith("\"")) {
- //#201132 property cannot end with 2 double quotes, add a
space to the end after our quote to prevent the state
Review comment:
humm..I will put again this comment
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
