eirikbakke commented on a change in pull request #3102:
URL: https://github.com/apache/netbeans/pull/3102#discussion_r686237563
##########
File path: platform/openide.actions/src/org/openide/actions/HeapView.java
##########
@@ -112,17 +112,20 @@
}
TEXT_COLOR = c;
- c = UIManager.getColor("nb.heapview.highlight"); //NOI18N
- if (null == c) {
- c = new Color(255, 255, 255, 192);
- }
- OUTLINE_COLOR = c;
-
c = UIManager.getColor("nb.heapview.background"); //NOI18N
if (null == c) {
c = new Color(0xCEDBE6);
}
BACKGROUND_COLOR = c;
+
+ c = UIManager.getColor("nb.heapview.highlight"); //NOI18N
+ if (null == c) {
+ c = new Color(BACKGROUND_COLOR.getRed(),
Review comment:
Much better. Not sure what I was thinking with the white-based default...
##########
File path: platform/openide.actions/src/org/openide/actions/HeapView.java
##########
@@ -54,7 +54,7 @@
* <li> nb.heapview.background - Color of widget background
* <li> nb.heapview.foreground - Color of text
* <li> nb.heapview.chart - Color of area chart
- * <li> nb.heapview.background - Color of outline around the text, to provide
a contrast against
+ * <li> nb.heapview.highlight - Color of outline around the text, to provide a
contrast against
Review comment:
Yup, that was a typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
