eirikbakke opened a new pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115


   In a previous PR ( https://github.com/apache/netbeans/pull/2967 ), the tab 
components in the NetBeans window system were redesigned and modernized for the 
Windows LAF. This PR ports related tabcontrol improvements back into FlatLAF, 
and proposes a similar tab style for FlatLAF. See the attached screenshots.
   
   The proposed style, compared to the current FlatLAF style, makes the 
selected tab look like an actual "tab" with an actual rectangular border around 
it, while keeping the much simpler "separators only" look for unselected tabs. 
The proposed style also tightens up vertical space significantly, like in other 
LAFs. See the attached screenshots. The new tab controls work well on all HiDPI 
scaling levels, and on all platforms (Windows, Linux, MacOS).
   
   Advantages of the proposed tabcontrol style:
   * Other applications that have tabs as part of their window system still 
tend to render at least the active window system tab as an actual "tabs", e.g. 
Chrome, Excel, Photoshop, Unity.
   * Personally, I find it hard to orient my eyes around the old FlatLAF tab 
style; the drawn selected tab seems to fix this. (Hard to explain in a fully 
objective way!)
   * The tab content areas (contents of editor, projects pane, navigator pane 
etc.) has borders around them, so it is logical that the border continues 
around the tab that is associated with them.
   * Conserve vertical space. Modern monitors have tended to become wider but 
not taller. With e.g. 2x HiDPI scaling (as on all MacBooks), there may actually 
be _fewer_ logical pixels available in the vertical direction than on older 
laptop screens.
   
   This PR also removes an extraneous border around the editor area, and 
introduces a little bit of extra space in the toolbar area.
   
   I've been using FlatLAF as the default LAF on Linux for my NetBeans Platform 
application. It handles HiDPI scaling very well, and it's getting really 
solid--thanks to @DevCharly for all his work on it!
   
   ### Before/after screenshots, FlatLAF Light:
   
![flatlaf-light-1-before](https://user-images.githubusercontent.com/886243/129835780-db2f95a6-012d-4973-8e38-ab84c2c67e18.png)
   
![flatlaf-light-2-after](https://user-images.githubusercontent.com/886243/129835845-bc76a9bc-65c1-48aa-91dd-be0fbadfc2ea.png)
   
   ### Before/after screenshots, FlatLAF Dark:
   
![flatlaf-dark-1-before](https://user-images.githubusercontent.com/886243/129835816-3c953cab-4624-4d39-b041-dffc47c7f925.png)
   
![flatlaf-dark-2-after](https://user-images.githubusercontent.com/886243/129835819-0733dd6b-0ce9-47c7-87a0-a60feaf804cf.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to