matthiasblaesing commented on a change in pull request #3153:
URL: https://github.com/apache/netbeans/pull/3153#discussion_r704649861
##########
File path: ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
##########
@@ -400,9 +403,17 @@ public InitializeResult getInitResult() {
return initResult;
}
- @SuppressWarnings("AccessingNonPublicFieldOfAnotherObject")
+ @SuppressWarnings({"AccessingNonPublicFieldOfAnotherObject",
"NestedSynchronizedStatement"})
Review comment:
You mean the hint is wrong because the synchronisation is inside a
lambda, that is not executed in the containing method? My first though was,
that the hint is right, but after reading twice, you are right.
With the next push, this will be gone again, as as your proposed solution is
much easier and does not need explicit synchronisation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
