JaroslavTulach commented on a change in pull request #3186:
URL: https://github.com/apache/netbeans/pull/3186#discussion_r715035032
##########
File path:
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchDelegate.java
##########
@@ -508,7 +508,7 @@ public void finished(boolean success) {
if (provider == null) {
command = debug ? mainSource ? ActionProvider.COMMAND_DEBUG
- : ActionProvider.COMMAND_DEBUG //
DEBUG_TEST is missing?
+ : ActionProvider.COMMAND_TEST //TODO:
COMMAND_DEBUG_TEST is missing?
Review comment:
This change isn't very satisfying, right? Instead of being able to debug
something, we run tests with debugging disabled.
##########
File path: java/java.lsp.server/vscode/package.json
##########
@@ -4,7 +4,7 @@
"description": "Apache NetBeans Language Server Extension for Visual
Studio Code",
"author": "Apache NetBeans",
"license": "Apache 2.0",
- "version": "12.4.0",
+ "version": "12.5.0",
Review comment:
Please put hire `0.1.0` otherwise we are going to have changes with
every local `ant build-vscode-ext` - don't you see `0.1.0` automatically being
written into this location with every build?
##########
File path:
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TestSuiteInfo.java
##########
@@ -108,23 +109,23 @@ public void setFile(final String file) {
}
/**
- * The line within the specified file where the suite definition starts
(if known).
+ * The range within the specified file where the suite definition is
located (if known).
*/
@Pure
- public Integer getLine() {
- return line;
+ public Range getRange() {
Review comment:
Is this class a base for a JSON message transferred between LSP backend
and LSP client? If so, than this classifies as an API change. How are we going
to document/version this kind of API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
